-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Upgrade Supernova #8330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Supernova #8330
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found some issues that need attention. See inline comments for details.
| [K in ProviderName]?: Record<string, string> | ||
| } | ||
|
|
||
| const MODEL_MIGRATIONS: ModelMigrations = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P2: The migration map is typed as Record<string, string>. Narrow to RooModelId keys/values to catch typos at compile time.
| const MODEL_MIGRATIONS: ModelMigrations = { | |
| type ModelMigrations = { | |
| [K in ProviderName]?: Partial<Record<RooModelId, RooModelId>> | |
| } | |
| const MODEL_MIGRATIONS: ModelMigrations = { | |
| roo: { | |
| 'roo/code-supernova': 'roo/code-supernova-1-million', | |
| }, | |
| } as const |
| const newModelId = providerMigrations[apiConfig.apiModelId] | ||
| if (newModelId && newModelId !== apiConfig.apiModelId) { | ||
| console.log( | ||
| `[ModelMigration] Migrating ${apiConfig.apiProvider} model from ${apiConfig.apiModelId} to ${newModelId}`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P2: Prefer project logger/telemetry over console.log/console.error to reduce noise and centralize diagnostics. Consider emitting a dedicated event for model migrations.
| Object.values(providerProfiles.apiConfigs)[0]?.id ?? | ||
| this.defaultConfigId | ||
| providerProfiles.modeApiConfigs = Object.fromEntries(modes.map((m) => [m.slug, seedId])) | ||
| isDirty = true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P3: Migrations run on initialize(). Consider applying the same normalization step wherever providerProfiles are mutated (e.g., save/import) to keep configs normalized after startup.
| "roo/code-supernova": { | ||
| maxTokens: 16_384, | ||
| contextWindow: 200_000, | ||
| "roo/code-supernova-1-million": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P3: New ID and limits look good. Ensure any user-facing docs/help listing model IDs are updated to 'roo/code-supernova-1-million' to avoid confusion.
Important
Upgrade
roo/code-supernovatoroo/code-supernova-1-millionwith model migration and update UI elements and translations accordingly.roo/code-supernovatoroo/code-supernova-1-millioninroo.tswith increasedmaxTokensandcontextWindow.ProviderSettingsManager.tsto automatically update old model IDs to new ones.ProviderSettingsManager.spec.tsto verify model migration logic, including repeated migrations and handling of different providers.chat.jsoninca,de,en) to reflect the new model upgrade.latestAnnouncementIdinClineProvider.tstosep-2025-code-supernova-1m.This description was created by
for 17d8470. You can customize this summary. It will automatically update as commits are pushed.