Skip to content

Conversation

@mrubens
Copy link
Collaborator

@mrubens mrubens commented Sep 26, 2025

Important

Upgrade roo/code-supernova to roo/code-supernova-1-million with model migration and update UI elements and translations accordingly.

  • Behavior:
    • Upgrade roo/code-supernova to roo/code-supernova-1-million in roo.ts with increased maxTokens and contextWindow.
    • Implement model migration in ProviderSettingsManager.ts to automatically update old model IDs to new ones.
  • Tests:
    • Add tests in ProviderSettingsManager.spec.ts to verify model migration logic, including repeated migrations and handling of different providers.
  • UI/Translations:
    • Update announcement text in multiple language files (e.g., chat.json in ca, de, en) to reflect the new model upgrade.
    • Change latestAnnouncementId in ClineProvider.ts to sep-2025-code-supernova-1m.

This description was created by Ellipsis for 17d8470. You can customize this summary. It will automatically update as commits are pushed.

Copy link
Contributor

@roomote roomote bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found some issues that need attention. See inline comments for details.

[K in ProviderName]?: Record<string, string>
}

const MODEL_MIGRATIONS: ModelMigrations = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: The migration map is typed as Record<string, string>. Narrow to RooModelId keys/values to catch typos at compile time.

Suggested change
const MODEL_MIGRATIONS: ModelMigrations = {
type ModelMigrations = {
[K in ProviderName]?: Partial<Record<RooModelId, RooModelId>>
}
const MODEL_MIGRATIONS: ModelMigrations = {
roo: {
'roo/code-supernova': 'roo/code-supernova-1-million',
},
} as const

const newModelId = providerMigrations[apiConfig.apiModelId]
if (newModelId && newModelId !== apiConfig.apiModelId) {
console.log(
`[ModelMigration] Migrating ${apiConfig.apiProvider} model from ${apiConfig.apiModelId} to ${newModelId}`,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: Prefer project logger/telemetry over console.log/console.error to reduce noise and centralize diagnostics. Consider emitting a dedicated event for model migrations.

Object.values(providerProfiles.apiConfigs)[0]?.id ??
this.defaultConfigId
providerProfiles.modeApiConfigs = Object.fromEntries(modes.map((m) => [m.slug, seedId]))
isDirty = true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P3: Migrations run on initialize(). Consider applying the same normalization step wherever providerProfiles are mutated (e.g., save/import) to keep configs normalized after startup.

"roo/code-supernova": {
maxTokens: 16_384,
contextWindow: 200_000,
"roo/code-supernova-1-million": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P3: New ID and limits look good. Ensure any user-facing docs/help listing model IDs are updated to 'roo/code-supernova-1-million' to avoid confusion.

@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Sep 26, 2025
@daniel-lxs daniel-lxs moved this from Triage to PR [Draft / In Progress] in Roo Code Roadmap Sep 26, 2025
@hannesrudolph hannesrudolph added PR - Draft / In Progress and removed Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. labels Sep 26, 2025
@mrubens mrubens marked this pull request as ready for review September 26, 2025 19:36
@mrubens mrubens requested review from cte and jr as code owners September 26, 2025 19:36
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Sep 26, 2025
@mrubens mrubens merged commit 8a7d90e into main Sep 26, 2025
21 of 22 checks passed
@mrubens mrubens deleted the supernova_1m branch September 26, 2025 19:37
@github-project-automation github-project-automation bot moved this from PR [Draft / In Progress] to Done in Roo Code Roadmap Sep 26, 2025
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Sep 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR - Draft / In Progress size:L This PR changes 100-499 lines, ignoring generated files.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants